Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for bad placeholder errors on consts/statics with trait objects #83739

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Account for bad placeholder errors on consts/statics with trait objects #83739

merged 1 commit into from
Jun 21, 2021

Conversation

JohnTitor
Copy link
Member

Fixes #75889
r? @estebank

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 1, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@crlf0710 crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2021
@Dylan-DPC-zz
Copy link

looks good to me

r? @Dylan-DPC

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented May 4, 2021

📌 Commit 79f0bcc64ab92684cb702f785e017544d67c22ae has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2021
@JohnTitor
Copy link
Member Author

@Dylan-DPC Hm, I don't think you're on the t-compiler, the release team can approve such a PR? And rollup status and priority don't seem suitable.

@Dylan-DPC-zz
Copy link

Dylan-DPC-zz commented May 4, 2021 •
edited
Loading

uggh yeah wrong rollup option my bad

@Dylan-DPC-zz
Copy link

@bors p=0 rollup=always

@Dylan-DPC-zz
Copy link

normally it's fine for smaller trivial prs. But if you want someone from compiler team to look at it, let me know. Not an issue

@JohnTitor
Copy link
Member Author

I'd ask a review from the compiler team to check if we don't have a diagnostic regression like #77431 (comment).
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 4, 2021
@Dylan-DPC-zz
Copy link

bah..

r? @estebank

@JohnTitor JohnTitor added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 4, 2021
@bstrie bstrie added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2021
@crlf0710 crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2021
@JohnTitor
Copy link
Member Author

Friendly-ping @estebank, I guess you overlooked this?

@estebank
Copy link
Contributor

@bors r+

@JohnTitor sorry, I've been out for the past few weeks.

@bors
Copy link
Contributor

bors commented Jun 20, 2021

📌 Commit 052d77e has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2021
@JohnTitor
Copy link
Member Author

No problem, thanks for reviewing!

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jun 21, 2021
@JohnTitor
Rollup merge of rust-lang#83739 - JohnTitor:issue-75889, r=estebank
cde49cf 
Account for bad placeholder errors on consts/statics with trait objects

Fixes rust-lang#75889
r? `@estebank`
This was referenced Jun 21, 2021
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 21, 2021
@bors
Auto merge of rust-lang#86502 - JohnTitor:rollup-wge0f3x, r=JohnTitor
6a540bd 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#83739 (Account for bad placeholder errors on consts/statics with trait objects)
 - rust-lang#85637 (document PartialEq, PartialOrd, Ord requirements more explicitly)
 - rust-lang#86152 (Lazify is_really_default condition in the RustdocGUI bootstrap step)
 - rust-lang#86156 (Fix a bug in the linkchecker)
 - rust-lang#86427 (Updated release note)
 - rust-lang#86452 (fix panic-safety in specialized Zip::next_back)
 - rust-lang#86484 (Do not set depth to 0 in fully_expand_fragment)
 - rust-lang#86491 (expand: Move some more derive logic to rustc_builtin_macros)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1a1909a into rust-lang:master Jun 21, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jun 21, 2021
@JohnTitor JohnTitor deleted the issue-75889 branch June 21, 2021 04:23
fee1-dead added a commit to fee1-dead-contrib/rust that referenced this pull request Jun 21, 2021
@fee1-dead
Update rust-lang#83739 with type of the item specified
e66f241
@fee1-dead fee1-dead mentioned this pull request Jun 21, 2021
Merged
@JohnTitor JohnTitor mentioned this pull request Jun 22, 2021
Closed
@JohnTitor JohnTitor mentioned this pull request May 29, 2022
Merged
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jun 13, 2022
@JohnTitor
Rollup merge of rust-lang#97508 - JohnTitor:more-strict-placeholder-d…
aa71be1 
…yn-obj, r=pnkfelix

Harden bad placeholder checks on statics/consts

Resubmission of rust-lang#89161
Fixes rust-lang#88643

In rust-lang#83739, I added a check for trait objects on statics/consts but it wasn't robust. `is_suggestable_infer_ty` fn does a more strict check and finds more bad placeholders. See rust-lang#89161 (comment) for the more detailed explanation.

r? `@pnkfelix` as you're the reviewer of the previous PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.

MIR has errors when type of const is Fn with placeholder type
10 participants
@JohnTitor @rust-log-analyzer @Dylan-DPC-zz @bors @estebank @crlf0710 @bstrie @JohnCSimon @rust-highfive @rustbot